Skip to content

Store custom extension callbacks according to their extension types instead of function signature #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Store custom extension callbacks according to their extension types instead of function signature #2343

wants to merge 4 commits into from

Conversation

nicolaskagami
Copy link

Fixes: #2342

This PR does two things:

  • Improves the current custom extension test to have two invocations of add_custom_ext with different extension types but same callback function signatures. - This exemplifies the problem and serves as a regression test.
  • Changes the callbacks to have indices based on extension type instead of function signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple "custom extension" callbacks with same signature share indices
1 participant
@nicolaskagami